Fix linter errors on cosmos-sdk upgrade branch #2303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## replace-berachain-cosmos-sdk-point-local-repo-2 #2303 +/- ##
===================================================================================
+ Coverage 21.17% 31.02% +9.85%
===================================================================================
Files 3 333 +330
Lines 85 15422 +15337
Branches 20 20
===================================================================================
+ Hits 18 4785 +4767
- Misses 66 10311 +10245
- Partials 1 326 +325
|
…into fix-linter
Since newest cometbft defaults to timeout_commit of 0 we always default to that in our config.toml file as this code is generated by cosmossdk init function handler. To fix this properly I need to figure out how to pass in the config as context value to the cobra.command as a viper instance. Until then putting this error here as to preventing us forgetting to set it to the correct time_commit (which I assume will be 1sec)
calbera
reviewed
Dec 19, 2024
calbera
approved these changes
Dec 19, 2024
calbera
merged commit 706c91e
into
replace-berachain-cosmos-sdk-point-local-repo-2
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.